Skip to content

Port TS PR 61144 (Pass ignoreErrors=true to more resolveEntityName callers) #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Port TS PR 61144 (Pass ignoreErrors=true to more resolveEntityName callers) #1253

merged 1 commit into from
Jun 24, 2025

Conversation

jakebailey
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings June 21, 2025 06:22
Copilot
Copilot AI reviewed Jun 21, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ports changes from TS PR 61144 by updating how errors are handled in entity name resolution within the checker.

  • Changed the ignoreErrors flag from false to true in two calls to c.resolveEntityName.
  • Aligns behavior with upstream changes to match expected TypeScript error handling.
Comments suppressed due to low confidence (2)

@jakebailey jakebailey changed the title Port TS PR 61144 Port TS PR 61144 (Pass ignoreErrors=true to more resolveEntityName callers) Jun 23, 2025
@jakebailey jakebailey added this pull request to the merge queue Jun 24, 2025
Merged via the queue into main with commit ed1c512 Jun 24, 2025
22 checks passed
@jakebailey jakebailey deleted the jabaile/port-61144 branch June 24, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakebailey @DanielRosenwasser